On May 1st General Giap orders the Viet Minh army to attack the remaining French defensive positions, most of the attacks are successful. The French are greatly outnumbered and even the wounded are pressed into service. French resistance ends on May 7th. General Ely becomes the French Army commander in Indochina a biography of him. The French Government falls and the new premier promised to end the war in Indochina within 30 days.